Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngOptions): explain using 'select as' and 'track by' together #13000

Closed
wants to merge 1 commit into from
Closed

docs(ngOptions): explain using 'select as' and 'track by' together #13000

wants to merge 1 commit into from

Conversation

ryanhart2
Copy link
Contributor

  • change warning to indicate that 'select as' and 'track by' can be used together with care
  • provide an example that will work and an example that will not work
  • provide a simple explanation of why the non-working example does not work

@ryanhart2
docs(ngOptions): explain using 'select as' and 'track by' together
60a69a1 
* change warning to indicate that 'select as' and 'track by' can be used together with care
* provide an example that will work and an example that will not work
* provide a simple explanation of why the non-working example does not work
@ryanhart2 ryanhart2 mentioned this pull request Oct 2, 2015
Closed
@ryanhart2 ryanhart2 closed this Oct 3, 2015
@ryanhart2 ryanhart2 reopened this Oct 3, 2015
gkalpak
gkalpak reviewed Oct 4, 2015
View reviewed changes
src/ng/directive/ngOptions.js
* ```
*
* In both examples the **`track by`** expression is applied sucessfully to each `item` in `items`. It is also
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sucessfully --> successfully

@gkalpak
Copy link
Member

gkalpak commented Oct 4, 2015

@ryanhart2, could you fix the typo and amend the commit message to add #Fixes 11768 (so it get's closed automatically) ?

@ryanhart2
Copy link
Contributor Author

Thanks @gkalpak, I will do that. I also realized that I didn't remove all of the previous example that I was replacing; I need to remove rows 83 to 94.

@ryanhart2 ryanhart2 closed this Oct 4, 2015
@ryanhart2 ryanhart2 deleted the patch-2 branch October 4, 2015 13:26
@ryanhart2
Copy link
Contributor Author

Sorry @gkalpak, I messed that up. I deleted the origin branch and pushed again, instead of a force push. The updated pull request is #13007.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanhart2 @gkalpak @googlebot