Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Added a comment on a misleading declaration on the $location guide #12987

Closed
wants to merge 1 commit into from
Closed

Added a comment on a misleading declaration on the $location guide #12987

wants to merge 1 commit into from

Conversation

williamtroy
Copy link

When the guide is followed correctly, a seemingly innocuous $sniffer value is
set on the module. For the new developer this is pretty normal. But what is
completely hidden is that setting this value in that way, will silently prevent
all animations from ngAnimate.
Unless the developer knows that the value is not intended to be modified
(it's an internal service after all, it usually never is) they might
end up breaking their animations unknowingly.

When the guide is followed correctly, a seemingly innocuous $sniffer value is
 set on the module. For the new developer this is pretty normal.  But what is
completely hidden is that setting this value in that way, will silently prevent
all animations from ngAnimate. 
Unless the developer knows that the value is not intended to be modified
(it's an internal service after all, it usually never is) they might
end up breaking their animations unknowingly.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@williamtroy
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 1, 2015
@Narretz Narretz closed this in f047ad2 Oct 1, 2015
Narretz added a commit that referenced this pull request Oct 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants