Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Typo/mismatch fix #12834

Closed
wants to merge 1 commit into from
Closed

Typo/mismatch fix #12834

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2015

There is an mismatch for status in controller and test.
In controller $scope.status = 'ERROR!' and in test we expect($rootScope.status).toBe('Failed...') so the test will fail;

There is an mismatch for status in controller and test. 
In controller $scope.status = 'ERROR!' and in test we expect($rootScope.status).toBe('Failed...') so the test will fail;
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ghost
Copy link
Author

ghost commented Sep 13, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Narretz Narretz closed this in 159efdd Sep 13, 2015
@ghost
Copy link
Author

ghost commented Sep 13, 2015

@Narretz You don't agree with my suggestion ? Please look at $htmlBackend docs https://docs.angularjs.org/api/ngMock/service/$httpBackend

@gkalpak
Copy link
Member

gkalpak commented Sep 14, 2015

@toastman, he must totally agree with your suggestion, because he (@Narretz) merged it into master (159efdd) 😄

@ghost
Copy link
Author

ghost commented Sep 14, 2015

@gkalpak Thank you, I'm just misunderstood ("This pull request is closed, but the toastman:patch-1 branch has unmerged commits.")

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants