This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animateCss): use timing functions when present #12666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses transition timing functions when present in styles instead of defaulting to `linear`
|
@matsko Could you give this a look? |
| @@ -232,6 +233,8 @@ var DETECT_STAGGER_CSS_PROPERTIES = { | |||
| animationDelay: ANIMATION_DELAY_PROP | |||
| }; | |||
|
|
|||
| var TRANSITION_EASING_VALUE = /ease|ease-in|ease-out|ease-in-out|linear|step-start|step-end|steps\(.+\)|cubic-bezier\(.+\)/; | |||
There was a problem hiding this comment.
the regex fails when I have something like transition: 1s ease-in-out color' (It will take the first match, which is ease).
|
Closing this due to #13333 superceding this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linearThis is for #12656.
I need some guidance here @matsko - the style information is needed from the element on call to $animateCss when doing class manipulation, but I am not sure the best way to cache/retrieve the information here. Would you advise using the existing
computeCachedCssStylesmethod here?