Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix test issue #12590

Closed
wants to merge 1 commit into from
Closed

Fix test issue #12590

wants to merge 1 commit into from

Conversation

elviocb
Copy link
Contributor

@elviocb elviocb commented Aug 14, 2015

Unnecessary split. The url returns a string without the hash, resulting in an undefined value and making the test fails.

Unnecessary split. The url returns a string without the hash, resulting in an undefined value and making the test fails.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@elviocb
Copy link
Contributor Author

elviocb commented Aug 14, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@caitp
Copy link
Contributor

caitp commented Aug 14, 2015

in the actual phonecat codebase we're using toEqual() for some reason (???) but this (otherwise) matches up with it, so looks good to me

@caitp caitp closed this in 5df80e1 Aug 14, 2015
@elviocb elviocb deleted the elviocb-patch-1 branch November 6, 2019 03:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants