This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(sanitize): Do not duplicate self closing elements #12477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
lgalfaso
force-pushed
the
new-sanitize-fix
branch
2 times, most recently
from
9dd634d to
0e3a33b
Compare
This implementation is based on inert document Closes angular#11442 Closes angular#11443
For HTML self closing elements: * Do not create an end element * Create the element as self closed
lgalfaso
force-pushed
the
new-sanitize-fix
branch
from
0e3a33b to
0b39333
Compare
|
We should probably wait until 1.5 for this, right? |
Yep |
|
Close in favor of #12524 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refinement on top of #11790 that handles self closing elements