Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat($httpParamSerializerJQLike): honor object.toJSON function if present #12330

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/ng/http.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,14 @@ function $HttpParamSerializerJQLikeProvider() {
return parts.join('&');

function serialize(toSerialize, prefix, topLevel) {
if (toSerialize === null || isUndefined(toSerialize)) return;
if (toSerialize === null || isUndefined(toSerialize) || isFunction(toSerialize)) return;
if (isArray(toSerialize)) {
forEach(toSerialize, function(value, index) {
serialize(value, prefix + '[' + (isObject(value) ? index : '') + ']');
});
} else if (isObject(toSerialize) && !isDate(toSerialize)) {
} else if (isFunction(toSerialize.toJSON)) {
serialize(toSerialize.toJSON(), prefix, topLevel);
} else if (isObject(toSerialize)) {
forEachSorted(toSerialize, function(value, key) {
serialize(value, prefix +
(topLevel ? '' : '[') +
Expand Down
31 changes: 31 additions & 0 deletions test/ng/httpSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2274,6 +2274,37 @@ describe('$http param serializers', function() {
expect(jqrSer({someDate: new Date('2014-07-15T17:30:00.000Z')})).toEqual('someDate=2014-07-15T17:30:00.000Z');
});

it('should ignore functions', function() {
expect(jqrSer({
foo: {
a: 'b',
c: function() {
return 'd';
}
}
})).toEqual('foo%5Ba%5D=b');
});

it('should honor toJSON function', function() {
expect(jqrSer({
foo: {
a: 'b',
toJSON: function() {
return {
e: 'f',
g: 'h'
};
}
},
bar: {
c: 'd',
toJSON: function() {
return 'baz';
}
}
})).toEqual('bar=baz&foo%5Be%5D=f&foo%5Bg%5D=h');
});

});

describe('default array serialization', function() {
Expand Down