This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(select): select doesn't work when label and ngModel value match. #12189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
The selectCtrl ```addOption``` compares the label value with the ngModel value when determining when to set the value of the select element. This causes a problem if the label matches model value but not the selectAs value of the option. fixes angular#11835
|
CLAs look good, thanks! |
rgaskill
changed the title
|
We've decided not to fix this issue in 1.3.x. See #11835 (comment) for more info |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selectCtrl
addOptioncompares the label value with thengModel value when determining when to set the value of the select
element. This causes a problem if the label matches model value but
not the selectAs value of the option.
fixes #11835