Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

test($location): ensure mock window can be wrapped by jqLite #12086

Closed
wants to merge 1 commit into from
Closed

test($location): ensure mock window can be wrapped by jqLite #12086

wants to merge 1 commit into from

Conversation

caitp
Copy link
Contributor

@caitp caitp commented Jun 11, 2015

@caitp
Copy link
Contributor Author

caitp commented Jun 11, 2015

The fact that we have this bug in jqLite makes me suspicious that we might do the wrong thing with the real window object when there are e.g. iframes on the page (or even if there aren't)

It looks like the only safety check there is is that elements.window !== elements, so that's not ideal maybe. I'll update this to use that fix instead

@caitp caitp closed this in 571bee7 Jun 11, 2015
caitp added a commit that referenced this pull request Jun 12, 2015
@caitp @petebacondarwin
test($location): ensure mock window can be wrapped by jqLite
340e4da 
Fixin da build

Closes #12086
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
@caitp @netman92
test($location): ensure mock window can be wrapped by jqLite
b44d9c4 
Fixin da build

Closes angular#12086
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caitp @googlebot