docs(tutorial/Tutorial): mention package.json file #12040
Conversation
If reader does not cd into angular-phonecat subdirectory - npm install will not work. This comment helps newbies understand npm install is dependent on a custom project.json file.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
| @@ -129,7 +129,7 @@ Once you have Node.js installed on your machine you can download the tool depend | |||
| npm install | |||
| ``` | |||
|
|
|||
| This command will download the following tools, into the `node_modules` directory: | |||
| This command reads angular-phonecat's project.json file and will download the following tools, into the `node_modules` directory: | |||
There was a problem hiding this comment.
I assume you mean package.json?
There was a problem hiding this comment.
You're right. sorry for the typo. I fixed it in the branch.
On Mon, Jun 8, 2015 at 2:07 PM, Martin Staffa [email protected]
wrote:
In docs/content/tutorial/index.ngdoc
#12040 (comment):@@ -129,7 +129,7 @@ Once you have Node.js installed on your machine you can download the tool depend
npm install-This command will download the following tools, into the `node_modules` directory: +This command reads angular-phonecat's project.json file and will download the following tools, into the `node_modules` directory:I assume you mean package.json?
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/pull/12040/files#r31942048.
There was a problem hiding this comment.
How do I get out of these discussions? I'm not quite sure what this all means? Thanks!
Sent from my iPhone
On Jun 8, 2015, at 2:07 PM, Martin Staffa [email protected] wrote:
In docs/content/tutorial/index.ngdoc:
@@ -129,7 +129,7 @@ Once you have Node.js installed on your machine you can download the tool depend
npm install-This command will download the following tools, into the `node_modules` directory: +This command reads angular-phonecat's project.json file and will download the following tools, into the `node_modules` directory: I assume you mean package.json?
—
Reply to this email directly or view it on GitHub.
Typo fix
If the reader does not cd into angular-phonecat subdirectory, npm install will not work. This comment helps newbies understand npm install is dependent on a custom project.json file. Closes angular#12040
If reader does not cd into angular-phonecat subdirectory - npm install will not work. This comment helps newbies understand npm install is dependent on a custom project.json file.