This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): ensure that repeated structural calls during pre-digest function #11895
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st function Prior to this fix if `$animate.enter()` or `$animate.leave()` was called before a digest was issued then the element may not be cancelled early enough. This fix ensures that the previous structural animation is cancelled immediately when a follow-up animation is kicked off. Closes angular#11867
matsko
force-pushed
the
fix_duplicate_view_issue
branch
from
25c1158 to
97d266e
Compare
| $$rAF.flush(); | ||
| expect(enterComplete).toBe(true); | ||
| })); | ||
|
|
There was a problem hiding this comment.
Use spies:
it('should cancel the previous structural animation if a follow-up structural animation takes over before the postDigest',
inject(function($animate, $$rAF) {
var enterDone = jasmine.createSpy('enter animation done');
$animate.enter(element, parent).done(enterDone);
expect(enterDone).not.toHaveBeenCalled();
$animate.leave(element);
$$rAF.flush();
expect(enterDone).toHaveBeenCalled();
}));
|
Except for not using spies, LGTM |
|
Landed as 2327f5a. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix if
$animate.enter()or$animate.leave()was calledbefore a digest was issued then the element may not be cancelled early
enough. This fix ensures that the previous structural animation is
cancelled immediately when a follow-up animation is kicked off.
Closes #11867