This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Changes and fixes to CSS Anchored Animations #11825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2015
| @@ -399,10 +399,12 @@ | |||
| * called `ng-animate-ref`. | |||
| * | |||
| * Let's say for example we have two views that are managed by `ng-view` and we want to show | |||
| * that there is a relationship between two components situated in different views. By using the | |||
| * that there is a relationship between two components situated in within these views. By using the | |||
BREAKING CHANGE: if your CSS code made use of the `ng-animate-anchor` CSS class for referencing the anchored animation element then your code must now use `ng-anchor` instead.
…re retained This patch ensures that all of the CSS classes that exist on both anchor nodes (the nodes that contain a `ng-animate-ref` attribute) are not removed from the cloned element during the anchor animation. (Previously the `in` animation would accidentally remove the CSS classes of the first element.) Closes angular#11681
…or` CSS class when triggering anchor animations
This fix changes anchored animations in ngAnimate to not append a series
of CSS classes with a `-suffix` prefix to the anchor element. Use
the `ng-anchor` instead CSS class instead.
BREAKING CHANGE: Prior to this fix there were to ways to apply CSS
animation code to an anchor animation. With this fix, the suffixed
CSS -anchor classes are now not used anymore for CSS anchor animations.
Instead just use the `ng-anchor` CSS class like so:
```html
<div class="container-animation" ng-if="on">
<div ng-animate-ref="1" class="my-anchor-element"></div>
</div>
<div class="container-animation" ng-if="!on">
<div ng-animate-ref="1" class="my-anchor-element"></div>
</div>
```
**before**:
```css
/* before (notice the container-animation CSS class) */
.container-animation-anchor {
transition:0.5s linear all;
}
```
**now**:
```css
/* now (just use `ng-anchor` on a class that both the
elements that contain `ng-animate-ref` share) */
.my-anchor-element.ng-anchor {
transition:0.5s linear all;
}
```
|
LGTM (from Igor in person) |
|
Landed as df24410 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.