chore(jscs): active disallowMultipleLineBreaks rule #11794
Conversation
|
not a fan of this, the vertical whitespace between blocks makes a lot of sense, and is used in other goog projects like closure-library and v8 --- plus it's unnecessary churn |
|
@caitp I'm not a fan of this too. But as this rule is listed in .jscs.json.todo I thought "it's an open TODO - I'll try to fix it". |
|
It makes perfect sense for linebreaks that aren't between function definitions/their surrounding comments --- but I'd prefer we enforce that there are two blank lines between function definitions. Still, since that will cause a lot of churn, it's probably not worth it |
|
I think we meant to remove that TODO list now. I think we agreed not to implement any more of those rules. |
|
Yeah I think I forgot to remove the file a while ago - was from #10772 (comment). Can do a PR to remove / update jscs? |
|
Ok guys, I close this PR |
No description provided.