This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): Fix text node animation #11722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to comment stripping code to return text nodes in addition to element nodes Closes #11703
|
This PR seems a bit buggy still. Please don't merge it. |
This was referenced Apr 29, 2015
|
It appears that the unresolved issues with this PR was a result of the library that I was testing it against. It resulted in some early remove animation not taking effect. I have submitted a PR to fix said library at rubenv/angular-gettext#187. This PR should be fine to merge. |
|
Fixed by #11803 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to comment stripping code to return text nodes in addition to element nodes
Closes #11703