-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
It allows to accept routes like `edit/color/:color/largecode/*largecode` to match with something like this `http://appdomain.com/edit/color/brown/largecode/code/with/slashs` **I really need it because my app ids contains slashs.**
Tested working, (thanks) |
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): For corporations (print, sign and scan+email, fax or mail): |
I have accepted the contributor agreement. Regarding adding tests, I could, but maybe in about a week or two because I am a little busy right now. |
Would like to see this feature in angular. |
It would be very useful addition to angular's routing system. It is a pity that this PR doesn't have an associated test nor documentation changes :-( Also, this PR introduces a new syntax for route params, so we would have:
On top of this I'm not clear if those catch-all routes should be supported only at the end of a URL or in a middle as well. Test and documentation changes should explain this. @andresmoschini are you planning to add tests / documentation to this PR? |
I am sorry, but we are not using Angular right now and I am a little busy to add test and documentation. Right now both |
I also find it a rather useful improvement. @andresmoschini and @pkozlowski-opensource , would you mind if I implement the required tests and the documentation? |
@lrlopez Luis, yes, I saw many people asking for this feature and it could be quite useful addition. Unfortunately this can't be merged as-is, without tests and documentation. So yes, if you've got time and energy to work on this a PR would be welcomed. You can either liaise with @andresmoschini or open a completely new PR. |
You're right. I think the best course is to pull @andresmoschini 's commit in my own repo and then add the tests/documentation changes. I'll issue a new PR over the master branch and publish a link here. Thanks! |
Thanks @lrlopez !, Please let me know when you push the changes to update my project with the official version. Feel free to change the API, I mean, I am not sure if |
A new PR #1559 suppresses this one. |
It allows to accept routes like
edit/color/:color/largecode/*largecode
to match with something like thishttp://appdomain.com/edit/color/brown/largecode/code/with/slashs
.I really need it because my app ids contains slashs.