Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngAnimate): ensure that minified repaint code isn't removed #11469

Closed
wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Mar 31, 2015

Closes #9936

1.2 / 1.3 / 1.4

@matsko matsko force-pushed the fix_minified_code branch from 6cc38b8 to 7cd1b70 Compare March 31, 2015 06:30
@petebacondarwin
Copy link
Contributor

LGTM. @Narretz does this work for you?

@matsko
Copy link
Contributor Author

matsko commented Mar 31, 2015

@petebacondarwin @Narretz's code was having issues with #11336. So this PR won't be compatible with the issues he's facing. However this issue still does exist for other versions of Angular and this patch corrects that.

@Narretz
Copy link
Contributor

Narretz commented Mar 31, 2015

I'll check in 30 minutes 😊

----- Ursprüngliche Nachricht -----
Von: "Pete Bacon Darwin" [email protected]
Gesendet: ‎31.‎03.‎2015 08:43
An: "angular/angular.js" [email protected]
Cc: "Martin Staffa" [email protected]
Betreff: Re: [angular.js] fix(ngAnimate): ensure that minified repaint codeisn't removed (#11469)

LGTM. @Narretz does this work for you?

Reply to this email directly or view it on GitHub.

@petebacondarwin
Copy link
Contributor

Fine by me
On 31 Mar 2015 08:04, "Matias Niemelä" [email protected] wrote:

@petebacondarwin https://github.com/petebacondarwin @Narretz
https://github.com/Narretz's code was having issues with #11336
#11336. So this PR won't be
compatible with the issues he's facing. However this issue still does exist
for other versions of Angular and this patch corrects that.


Reply to this email directly or view it on GitHub
#11469 (comment).

@Narretz
Copy link
Contributor

Narretz commented Mar 31, 2015

Ah, I didn't see this was a new issue. Interesting, I never had this problem in Firefox before. At least not as visible.

@matsko
Copy link
Contributor Author

matsko commented Mar 31, 2015

MERGED

Landed as:
c55a494
d5c99ea
b041b66

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different behavior angular-animate.js angular-animate.min.js (1.2.26) in Firefox 33.0.2
4 participants