This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngRepeat): improve the explanation of keys #11310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve grammar and phrasing on lines 36/37. The existing language uses poor grammar. Another possible replacement is "the order in which keys are returned," but the keys are not actually returned in any order--they are all returned at once, and they have an order. The best phrasing seems to be "the order of keys returned." An even better explanation might actually say what function is returning the keys eg Object.keys. This might read something like "You need to be aware that the JavaScript specification does not define the order of keys returned by Object.keys()," however it is not clear if the original author was referring to Object.keys().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve grammar and phrasing on lines 36/37. The existing language uses poor grammar. Another possible replacement is "the order in which keys are returned," but the keys are not actually returned in any order--they are all returned at once, and they have an order. The best phrasing seems to be "the order of keys returned." An even better explanation might actually say what function is returning the keys eg Object.keys. This might read something like "You need to be aware that the JavaScript specification does not define the order of keys returned by Object.keys()," however it is not clear if the original author was referring to Object.keys().