Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Changed aria-live attribute value from polite to assertive #11280

Closed
wants to merge 1 commit into from

Conversation

RaphStein
Copy link
Contributor

For ngMessages directive ngAria generates aria-live with value assertive and not polite.

For ngMessages directive ngAria generates aria-live with value assertive and not polite.
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@Narretz
Copy link
Contributor

Narretz commented Mar 12, 2015

Hi, thanks for the PR! Can you please sign the CLA?

@Narretz Narretz added this to the Backlog milestone Mar 12, 2015
@RaphStein
Copy link
Contributor Author

Hi, i have signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@Narretz Narretz closed this in e0e40e8 Mar 21, 2015
Narretz pushed a commit that referenced this pull request Mar 21, 2015
For ngMessages directive ngAria generates aria-live with value assertive and not polite.

Closes #11280
@marcysutton
Copy link
Contributor

"Assertive" was added for a reason: so that feedback would be given immediately as users type in text inputs. We talked about making this a configuration option, was that not considered?

@Narretz
Copy link
Contributor

Narretz commented Apr 13, 2015

I'm not sure if I follow; is this now incorrect? It was only a change in the docs to match the behavior in code, so I assumed it was safe.

@marcysutton
Copy link
Contributor

Ah ha, I totally read that wrong! Disregard. :)

netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
For ngMessages directive ngAria generates aria-live with value assertive and not polite.

Closes angular#11280
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants