This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): Change to falsy value in addClass and removeClass #11273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
fix/set-class-arg
branch
from
9dd1c47 to
a49afd4
Compare
wesleycho
changed the title
wesleycho
force-pushed
the
fix/set-class-arg
branch
2 times, most recently
from
abbc51b to
62ab63b
Compare
- Change addClass & removeClass to pass in null to setClass so $$setClassImmediately does not trigger due to arrays always being truthy - Change to use `null` instead - Revert to string
wesleycho
force-pushed
the
fix/set-class-arg
branch
from
62ab63b to
dc35ce6
Compare
|
Closing, this does not look quite right - need to think some more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$$setClassImmediately does not trigger due to arrays always being
truthy
This fixes #11268 .