This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(tutorial/0 - Bootstrapping): Clarifying where the callback is defined #11270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fined. Saying that the script-tag register a callback was for me very confusing, and I think specifying that it is the code in the script that registers the callback makes this a bit clearer.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
Signed the CLA. |
|
CLAs look good, thanks! |
|
Hi, thanks for the PR! I committed another version, which I found a bit simpler. Thanks for the contribution though! |
Narretz
added a commit
that referenced
this pull request
Mar 8, 2015
hansmaad
pushed a commit
to hansmaad/angular.js
that referenced
this pull request
Mar 10, 2015
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saying that the script-tag registers a callback was for me very confusing, and I think specifying that it is the code in the script that registers the callback makes this a bit clearer.