docs(orderBy): Start with a simpler example. #11144
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
cla:yes. |
|
CLAs look good, thanks! |
|
This is a good idea. However, I think it would be better if the new example 1 and example 2 had an introductory sentence, explaining which features of order By are used in the example. Could you add this? |
Per the question raised at this Stack Overflow question: http://stackoverflow.com/questions/24048590/angularjs-ng-repeat-orderby-date-not-working The first example on this page is too complex to convey the simplest possible case for using this function. Sentences to put examples 1 and 2 in context.
|
Sounds good. Thanks. I have updated the commit (with a rebase / squash) to add a couple of sentences describing each example. |
Per the question raised at this Stack Overflow question: http://stackoverflow.com/questions/24048590/angularjs-ng-repeat-orderby-date-not-working The first example on this page is too complex to convey the simplest possible case for using this function. Closes #11144
|
Thanks, landed! I had to make a few adjustments - the new example didn't actually work: if you don't use a scope property for your predicate, you need to make it a string literal: |
|
You're very welcome. I'm glad you caught my mistake, too. The updated example will be very helpful for programmers who just recently speed Angular. Thanks for merging it. |
Per the question raised at this Stack Overflow question: http://stackoverflow.com/questions/24048590/angularjs-ng-repeat-orderby-date-not-working The first example on this page is too complex to convey the simplest possible case for using this function. Closes angular#11144
Per the question raised at this Stack Overflow question: http://stackoverflow.com/questions/24048590/angularjs-ng-repeat-orderby-date-not-working The first example on this page is too complex to convey the simplest possible case for using this function. Closes angular#11144
Per the question raised at this Stack Overflow question:
http://stackoverflow.com/questions/24048590/angularjs-ng-repeat-orderby-date-not-working
The first example on this page is too complex to convey the simplest possible case for using this function.