This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf($compile): avoid .data when fetching required controllers #11059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| value.push(getControllers(directiveName, require, $element, elementControllers)); | ||
| }); | ||
| value = new Array(i = require.length); | ||
| while (i--) { |
There was a problem hiding this comment.
nit: I find
for (i=0, ii = requite.length; i < ii; ++i) {
...
}much easier to read (unless that for some specific reason we want to run this in reverse order)
|
otherwise, LGTM |
jbedard
force-pushed
the
compile-controller-perf-getcontrollers
branch
from
e66fca7 to
1a818a2
Compare
|
Updated... |
|
landed as fa0aa83 |
lgalfaso
pushed a commit
that referenced
this pull request
Feb 16, 2015
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
getControllersto try fetching controllers fromelementControllerswhich in many cases can avoid calling.data. For a largetable-bp benchmark of<input ng-model="foo">elements this reduces the create step GC about 50% (which seems crazy, but that's what chrome keeps claiming...) and improves the time 5-10%.(this was originally part of #9772)