feat(ngSwitch): add an optional attribute ngSwitchWhenSeparator

[lgalfaso]

Adds an optional attribute ngSwitchWhenSeparator that allows multiple tokens to match a given ngSwitchWhen.

Closes #3410
Closes #3516

[Narretz]

Does the separator need to be customizable? Why not settle on comma?

[gkalpak]

Typo: separator

[lgalfaso]

thx

[gkalpak]

Does the separator need to be customizable? Why not settle on comma?

@Narretz: I guess it is to enable using , in the value (not as a separator).

@lgalfaso: This might be a little farfetched, but it would be nice to allow setting the "default" separator on ng-switch (instead of having to use it on every ng-switch-when). E.g.:

<ng-switch ng-switch-separator="|">
    <ng-switch-when="a|b">A or B</ng-switch-when>
    <ng-switch-when="c|d">C or D</ng-switch-when>
    <ng-switch-when="|+$" ng-switch-separator="+">
        | or $ (local separator overwrites default)
    </ng-switch-when>
</ng-switch>

[lgalfaso]

Does the separator need to be customizable? Why not settle on comma?

this would be a breaking change (that I am trying to avoid)

This might be a little farfetched, but it would be nice to allow setting the "default" separator

if there is some interest in this PR, then we can think about adding a default separator... doing so would be relatively easy

[bricss]

Very needed feature, please merge it down.

[petebacondarwin]

What if we made ngSwitchWhenSeparator a directive of its own that ngSwitch could "require". This way you could specify it as an ancestor and it would affect all descendants (similar to how ngModelOptions works)

[Narretz]

This would be pretty cool! A global configuration is probably not a good idea, because you cannot control what templates other modules might use.

[lgalfaso]

@petebacondarwin making it another directive could give some unexpected results. Eg.

<div ng-switch="mode">
  <p ng-switch-when="a|b" ng-switch-when-separator="|"><span other-directive/></p>
  <p ng-switch-default>X</div>
</div>

if otherDirective has a ngSwitch, then it could end up using an unexpected ngSwitchWhenSeparator.

[petebacondarwin]

@lgalfaso OK, let's leave it as it is. Shame that we traverse up past isolated scope boundaries when doing require :-)

[gkalpak]

I still believe that moving ngSwitchWhenSeparator to ngSwitch (#10798 (comment)) is better, but it LGTM.

[Narretz]

@gkalpak Now that you say it, I think it makes sense. Although I guess that custom separators will be used quite rarely anyway (only when the default operator is a value).

[gkalpak]

What default operator?

[Narretz]

Yeah, there's no default value of course. Merged to both master and 1.5.x. We can put this attribute on the ngSwitch later on.