This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($templateRequest) remove repeated decrementation and unnecessar... #10780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KELiON thnx for the PR, it looks good after a quick look. There is a build failure, though, due to some style check errors, see: https://travis-ci.org/angular/angular.js/jobs/47259355 Could please fix those so we can merge this PR? Thnx! |
KELiON
force-pushed
the
refactor-template-request
branch
2 times, most recently
from
46f0eed to
85c67b5
Compare
…sary local variable
KELiON
force-pushed
the
refactor-template-request
branch
from
85c67b5 to
f3873ad
Compare
|
@pkozlowski-opensource thanks for review, I fixed style check errors. Now all tests passed locally, but build still broken and I can't find reason in travis ci. Where is it? |
|
@KELiON TravisCI builds are very flaky recently... I've restarted the build to see how the things go. If TravisCI is happy I'm going to merge this one. |
pkozlowski-opensource
pushed a commit
to pkozlowski-opensource/angular.js
that referenced
this pull request
Jan 18, 2015
…ssary local variable Closes angular#10780
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jan 20, 2015
…ssary local variable Closes #10780
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...y local variable