This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Adding ng-jq functionality, the ability to choose your angular.element l... #10750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t library or force jqLite even if jquery is available.
This was referenced Jan 14, 2015
| @@ -1147,7 +1177,7 @@ function snake_case(name, separator){ | |||
|
|
|||
| function bindJQuery() { | |||
| // bind to jQuery if present; | |||
| jQuery = window.jQuery; | |||
| jQuery = jq() ? window[jq()] : window.jQuery; | |||
There was a problem hiding this comment.
I think this will not do what you are expecting as '' is falsy
There was a problem hiding this comment.
BTW, please do not call jq() twice
There was a problem hiding this comment.
@lgalfaso hm, guess I need to change my unit tests then. Thanks for the heads up. Will change right now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ibrary or force jqLite even if jquery is available.