fix(ngModelOptions): allow sharing options between multiple inputs #10673

shahata · 2015-01-07T21:49:43Z

lgalfaso · 2015-01-08T11:37:17Z

landed as 9c9c6b3

jbedard · 2015-01-08T18:02:34Z

src/ng/directive/ngModel.js

@@ -1215,7 +1215,7 @@ var ngModelOptionsDirective = function() {
    restrict: 'A',
    controller: ['$scope', '$attrs', function($scope, $attrs) {
      var that = this;
-      this.$options = $scope.$eval($attrs.ngModelOptions);
+      this.$options = angular.copy($scope.$eval($attrs.ngModelOptions));


Really minor, and a bit late, but this should just be copy...

You are right, should be able to make the change in about an hour (unless
someone beats me)

done and thanks

Thanks & sorry. I always keep forgetting not to use angular.* :(

fix(ngModelOptions): allow sharing options between multiple inputs

4166b69

Closes #10667

googlebot added the cla: yes label Jan 7, 2015

lgalfaso closed this Jan 8, 2015

jbedard reviewed Jan 8, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ngModelOptions): allow sharing options between multiple inputs #10673

fix(ngModelOptions): allow sharing options between multiple inputs #10673

shahata commented Jan 7, 2015

lgalfaso commented Jan 8, 2015

jbedard Jan 8, 2015

lgalfaso Jan 8, 2015

lgalfaso Jan 8, 2015

shahata Jan 9, 2015

fix(ngModelOptions): allow sharing options between multiple inputs #10673

fix(ngModelOptions): allow sharing options between multiple inputs #10673

Conversation

shahata commented Jan 7, 2015

lgalfaso commented Jan 8, 2015

jbedard Jan 8, 2015

Choose a reason for hiding this comment

lgalfaso Jan 8, 2015

Choose a reason for hiding this comment

lgalfaso Jan 8, 2015

Choose a reason for hiding this comment

shahata Jan 9, 2015

Choose a reason for hiding this comment