This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(travis): update browsers to the latest version #10620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the used browsers to the latest versions available
lgalfaso
force-pushed
the
browser-update
branch
from
a4d10a0 to
e81eda2
Compare
|
@lgalfaso - there appear to be two fixes in this commit. |
petebacondarwin
added
type: bug
type: test
type: chore
needs: work
and removed
type: bug
labels
|
Newer versions of Safari do not update the calculated properties (after a programatic css change) synchronously. The change to the test is needed to make it pass in Safari (I can make it 2 commits, but just the browser update without the change on the test will make the test fail in Safari) |
|
You can always have commits that fail followed by commits that fix them as long as they are pushed together. But in this case, it is not needed. We just put the "fix" commit first. |
|
I guess we backport to 1.3.x |
petebacondarwin
added a commit
that referenced
this pull request
Jan 19, 2015
Update the used browsers to the latest versions available Closes #10620
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the used browsers to the latest versions available