Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngInclude): describe your change... #10594

Closed
wants to merge 2 commits into from
Closed

docs(ngInclude): describe your change... #10594

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf34492
docs(ngInclude): describe your change...
rus0000 Dec 29, 2014
35f0199
Update ngInclude.js
rus0000 Dec 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/directive/ngInclude.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<select ng-model="template" ng-options="t.name for t in templates">
<option value="">(blank)</option>
</select>
url of the template: <tt>{{template.url}}</tt>
url of the template: {{template.url}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to replace tt with code instead of getting rid of the element completely (it looks better to me) --- otherwise lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh, adding <code> would be much better as compared to simply removing those tags. @rus0000 could you please change <tt> => <code> and sign the CLA so we can merge this one?

<hr/>
<div class="slide-animate-container">
<div class="slide-animate" ng-include="template.url"></div>
Expand Down