Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor(ngScenario/ObjectModel.js): use Date.now() to get current Time #10579

Closed
wants to merge 1 commit into from

Conversation

HAKASHUN
Copy link
Contributor

@HAKASHUN HAKASHUN changed the title refactor(ngScenario/ObjectModel.js): use Date.now() for get current Time refactor(ngScenario/ObjectModel.js): use Date.now() to get current Time Dec 26, 2014
@pkozlowski-opensource
Copy link
Member

I think we can merge this now that IE8 is not officially supported. This refactoring won't change much in practice, but it is a bit cleaner - why not.

@HAKASHUN could you please sign the CLA so we can merge this PR?

@lgalfaso
Copy link
Contributor

@pkozlowski-opensource I understand that this can be orthogonal, but would like to see #10525 land first

@pkozlowski-opensource
Copy link
Member

@lgalfaso I don't mind either way but yes, it is totally orthogonal and simple refactoring so I wouldn't like to hold this one for too long if we intend to merge this PR. We've got way to many stale ones and I would like to clean up the backlog as much as possible.

@lgalfaso
Copy link
Contributor

Ok, makes sense

@HAKASHUN
Copy link
Contributor Author

@pkozlowski-opensource Thanks for your reply. I've just signed.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@HAKASHUN
Copy link
Contributor Author

@googlebot Sorry, I've just added my another email address for CLA.

@pkozlowski-opensource
Copy link
Member

@HAKASHUN you need to sign with the exact e-mail you've used to submit your patch

@HAKASHUN
Copy link
Contributor Author

@pkozlowski-opensource I confirmed the email in the patch. I've signed CLA with the exact email.

@googlebot
Copy link

CLAs look good, thanks!

@pkozlowski-opensource pkozlowski-opensource self-assigned this Dec 29, 2014
@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.3.9, Backlog Dec 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants