Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor(limitTo): no need for all those checks if we use slice #10537

Closed
wants to merge 1 commit into from
Closed

refactor(limitTo): no need for all those checks if we use slice #10537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 4 additions & 27 deletions src/ng/filter/limitTo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,34 +97,11 @@ function limitToFilter() {
limit = int(limit);
}

if (isString(input)) {
//NaN check on limit
if (limit) {
return limit >= 0 ? input.slice(0, limit) : input.slice(limit, input.length);
} else {
return "";
}
}

var i, n;

// if abs(limit) exceeds maximum length, trim it
if (limit > input.length)
limit = input.length;
else if (limit < -input.length)
limit = -input.length;

if (limit > 0) {
i = 0;
n = limit;
//NaN check on limit
if (limit) {
return limit > 0 ? input.slice(0, limit) : input.slice(limit);
} else {
// zero and NaN check on limit - return empty array
if (!limit) return [];

i = input.length + limit;
n = input.length;
return isString(input) ? "" : [];
}

return input.slice(i, n);
};
}