feat(angular.extend) - Simple non-breaking change to support deep extend

[prettycode]

People use angular.extend() as a utility function, whether or not it's designed for that purpose. It can easily be extended to support recursive merging with very very minor additions. Developers coming to Angular expect extend() to support this.

[googlebot]

CLAs look good, thanks!

[prettycode]

Is there a way to rerun the job that failed? It's a timeout, not an explicit (test) failure.

[lgalfaso]

git commit --amend --date "`date -R`"
git push -f

[lgalfaso]

also, please squash all the commits into one

[caitp]

nit: each of these declarations should have its own var for clarity

[lgalfaso]

simple question, why is it that angular.extends({}, angular.copy(foo)) not good enough? Is this just the fact that you have to also call angular.copy?

[caitp]

I think config = angular.extends({}, angular.copy(defaultConfig), angular.copy(config)); is a bit more verbose than it really needs to be.

I don't see a huge problem with adding this, not to say that there aren't things I dislike about it.

[caitp]

Oh, I should add that config = angular.extends({}, angular.copy(defaultConfig), angular.copy(config)); is semantically different from config = angular.extends({}, defaultConfig, config, true);

[caitp]

@petebacondarwin what's your opinion? Normally we just tell people to "use lodash", but it's not a very big change, I don't really see the harm in this one

[caitp]

If the value is null or undefined, Object.keys() will throw here... Don't worry about checking the type I guess, it's fine

[prettycode]

I'm afraid I may be in over my head here. Tried to squash the multiple commit (sorry) into one via this, but I'm still seeing multiple commits:

git rebase -i HEAD~8
git push -f

[caitp]

@prettycode what do you see when you run git rebase -i HEAD~8? you should get an editor screen, and you'll want to replace the "pick" on the left side of the last 7 commits with "f" to squash it. Careful not to squash too many =)

[caitp]

You misunderstood me in that last commit --- I mean on line 353, the condition should not be if (obj), it should be if (isObject(obj) || isFunction(obj))

[caitp]

Make this change, please.

[prettycode]

Thanks for your help, caitp! Sorry for my inexperience with git. Updating tests and the if(obj) check you referenced (the comment I misunderstood).

[petebacondarwin]

@caitp - Oh go on then :-)

[caitp]

if (isDeep) --argsLength;

We don't need to delete anything, it's slow, and deleting the argument doesn't really do anything meaningful (it doesn't change the length value). I said this in like the first 3 comments =)

[caitp]

If dst[key] is anything other than an object, we really need to replace it with an object --- I think copy() will use an Array if the source is an array, too.

[petebacondarwin]

Closing in favour of #10519