This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(browser): change mock location definition to use defineProperty #10497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original fix for which this mock location logic was written fixes a bug in master which also exists in 1.2.x. Cherry-picking the fix to the 1.2.x branch was difficult because the mock location object used ES5 get/set syntax, which is not supported in IE8. This fix changes the implementation to work with IE8 and modern browsers. IE8's defineProperty only works on certain types of objects, such as DOM elements. So the mock location is a div element in this implementation.
|
CLAs look good, thanks! |
|
@jeffbcross - Since 1.3.x doesn't support IE8 and 1.2.x is becoming less maintained as we move into 1.4 development mode is there much benefit in adding this complexity to the tests? |
|
There is some benefit if further fixes to master and 1.2.x will require changes to MockLocation inside browser. Cherry-picking will just require a little bit more work if they have different APIs, but I don't think it's the end of the world. I'll go ahead and close until a compelling reason to merge emerges. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix for which this mock location logic was written fixes
a bug in master which also exists in 1.2.x. Cherry-picking the fix
to the 1.2.x branch was difficult because the mock location object
used ES5 get/set syntax, which is not supported in IE8.
This fix changes the implementation to work with IE8 and modern
browsers.
IE8's defineProperty only works on certain types of objects, such as
DOM elements. So the mock location is a div element in this
implementation.