docs(guide/Unit Testing): tighter English #10478
Conversation
Leaner, more forceful style. Fixes a grammatical problems with subject number doesn't agrees with the verb. (originally "We have built many features into Angular which makes...", which reduces to "features...which makes"). More authoritative use of commas, such as the Oxford comma in lists of three or more. Sentences that are sentences, not fragments. (Yes, that was a fragment just now. I'm not writing docs now that reflect the polish of the project.) The English grammatical/stylistic notion of parallelism. Etc. This is just polish. The ideas are fine.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
@mcknell could you please sign the CLA so we can merge the proposed changes? Thnx! |
|
@mcknell did you sign the CLA? |
|
still waiting on a CLA signature @mcknell :'(. Just a note though, this seems to introduce some very long run-on sentences, it would probably be good to rewrite those better. |
|
@mcknell Since you've never signed the CLA, would you be okay with me committing these changes with my identity? |
|
When I go to view my CLA at https://cla.developers.google.com/clas , it indicates I signed a "Google Individual CLA" on May 17, 2015. I just added an "Android Individual CLA" today -- not sure why that would help, but thought I'd frob the system in case your searches were somehow stuck. @mcknell Since you've never signed the CLA, would you be okay with me committing these changes with my identity?— |
|
CLAs look good, thanks! |
| provide dependency injection for your XHR requests, which can be mocked, and we provide abstractions which | ||
| allow you to test your model without having to resort to manipulating the DOM. The test can then | ||
| assert that the data has been sorted without having to create or look at the state of the DOM or | ||
| With Angular, we try to make it easy for you to do the right thing. For your XHR requests, we |
There was a problem hiding this comment.
XHR requests is redundant, speaking of tighter english =) But I think it's okay anyways.
Leaner, more forceful style.
Fixes a grammatical problems with subject number doesn't agrees with the verb. (originally "We have built many features into
Angular which makes...", which reduces to "features...which makes").
More authoritative use of commas, such as the Oxford comma in lists of three or more.
Sentences that are sentences, not fragments. (Yes, that was a fragment just now. I'm not writing docs now that reflect the polish of the project.)
The English grammatical/stylistic notion of parallelism.
Etc. This is just polish. The ideas are fine.