This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(dateFilter): fix docs to match implementation for week no formatting #10445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
| @@ -356,8 +356,8 @@ var DATE_FORMATS_SPLIT = /((?:[^yMdHhmsaZEw']+)|(?:'(?:[^']|'')*')|(?:E+|y+|M+|d | |||
| * * `'.sss' or ',sss'`: Millisecond in second, padded (000-999) | |||
| * * `'a'`: AM/PM marker | |||
| * * `'Z'`: 4 digit (+sign) representation of the timezone offset (-1200-+1200) | |||
| * * `'ww'`: ISO-8601 week of year (00-53) | |||
| * * `'w'`: ISO-8601 week of year (0-53) | |||
| * * `'ww'`: Week of year, padded (00-53). Week 01 is assumed to contain the first Thur of a year. | |||
There was a problem hiding this comment.
We are not really assuming anything, I think it is better phrased as
Week of the year (00-53). Week 01 is the week with the first Thursday of the year
|
otherwise, LGTM |
…ting The existing documentation claims that dateFilter determines week no according to the ISO8601 standard, but this is not the case as illustrated by tests in this PR. More specifically, the implementation deviates from ISO8601 in 2 important aspects: - impl assumes Sun to be the first day of a week, ISO8601 mandates Mon - impl allows weeks 0 (for years starting on Fri, Sat) while ISO8601 would mark them as a week 52/53 of a previous year. Fixes angular#10314 Closes angular#10313
pkozlowski-opensource
force-pushed
the
week_no
branch
from
daa97f0 to
e1dfa27
Compare
|
Thnx @lgalfaso - updated docs as suggested. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing documentation claims that dateFilter determines week no
according to the ISO8601 standard, but this is not the case as illustrated
by tests in this PR. More specifically, the implementation deviates from
ISO8601 in 2 important aspects:
would mark them as a week 52/53 of a previous year.
Fixes #10314
Closes #10313
This PR is an alternative approach to the one proposed in #10313. Merging #10313 would introduce a breaking change without assuring full compliance with ISO-8601