This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($interpolate): remove some unnecessary logic, move functions out of closure #10413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
pkozlowski-opensource
modified the milestones:
1.4.0-beta.1 / 1.3.10,
1.4.0-beta.2 / 1.3.11
jbedard
force-pushed
the
interp-stringify
branch
from
f2e4257 to
2229c12
Compare
|
Anyone taken a look at this? Seemed worthwhile to me... |
|
It is odd that stringify(1) is no longer a string, the name of the function |
jbedard
force-pushed
the
interp-stringify
branch
from
2229c12 to
62621bb
Compare
|
That's true. I've removed that commit for now, can always do that later. Now there is just the one commit that moves the functions up... |
|
landed as 560951e |
lgalfaso
pushed a commit
that referenced
this pull request
Jan 27, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the functions out actually decreased memory usage 3% in the benchmark added in #10411 (according to benchpress when using chrome with the memory/gc params).