Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor(ngAria): DRY camelCase function #10336

Closed
wants to merge 1 commit into from

Conversation

cironunes
Copy link
Member

reuse the camelCase function from jqLite

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

reuse the camelCase function from jqLite
@gkalpak
Copy link
Member

gkalpak commented Dec 5, 2014

ngAria is an external module (not part of angular core). Hence, it doesn't have access to the private methods, such as camelCase (which is not a jqLite function btw).

This change will make ngAria tests fail.

@cironunes
Copy link
Member Author

@gkalpak yes. I just notice after the CI runs.
I'm going to close this an open another one.

@cironunes cironunes closed this Dec 5, 2014
@gkalpak
Copy link
Member

gkalpak commented Dec 5, 2014

@cironunes: Great (not sure what's going to be in that other one; not something camelCase-related I suppose).

BTW, you can run the tests locally and detect such errors before submitting PRs.

@cironunes
Copy link
Member Author

@gkalpak I opened another one because now the patch is a little more than just trying to reuse camelCase from jqLite.

Yeah yeah, I'm used to do grunt autotestwhich doesn't run test:modules(which test the external modules).

@cironunes
Copy link
Member Author

BTW this is the new one #10337

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants