refactor($templateRequest): avoid double calls to $templateCache.put

[pkozlowski-opensource]

Passing a $templateCache instance as part of the config (as here is enough to have the cache filled correctly, we don't need explicit calls to $templateCache.put.

We've got a test that proves that things work correctly after this change:

angular.js/test/ng/templateRequestSpec.js

Lines 19 to 29 in d0351c4

	it('should cache the request using $templateCache to prevent extra downloads',
	inject(function($rootScope, $templateRequest, $templateCache) {
	$templateCache.put('tpl.html', 'matias');
	var content;
	$templateRequest('tpl.html').then(function(html) { content = html; });
	$rootScope.$digest();
	expect(content).toBe('matias');
	}));

[googlebot]

CLAs look good, thanks!

[gkalpak]

The changes look good, but the test you refer to does not prove this works. In the test, we are putting the template into $templateCache manually, so it doesn't prove that the cache is actually populated by $templateRequest.

I think a new test is needed :)

[lgalfaso]

I agree with @gkalpak that a new test is needed

Somehow unrelated, what the test you point checks and it's description does not match

[pkozlowski-opensource]

@gkalpak @lgalfaso you are totally right, thnx for catching this one! I will push an updated version with another test. Scheduling it for 1.3.6 as it should be trivial to review.

[pkozlowski-opensource]

@gkalpak @lgalfaso I've re-worked the test to better reflect how people are using this service. The positive side effect of this change is that we can get rid of the $templateCache dependency in tests thus hiding implementation details of the $http cache.

[gkalpak]

It looks good (to me).
A general remark: Wouldn't it make sense to verify there are no outstanding expectations/requests after every $templateRequest test (just is case) ?

[lgalfaso]

LGTM