Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor($emplateRequest): simplify filtering out of transform functions #10264

Conversation

pkozlowski-opensource
Copy link
Member

I guess it might be just me but I find it a lot easier to read / understand this chunk of code when it is written using the .filter method.

Unless the code was written like this for perf reasons.

@googlebot
Copy link

CLAs look good, thanks!

@pkozlowski-opensource
Copy link
Member Author

Oh, it looks like I wasn't the only thinking about this change, see https://github.com/shahata/angular.js/commit/58042eefce097a4cd478e433116b39f9354a314d in #9745

@shahata
Copy link
Contributor

shahata commented Nov 29, 2014

I guess the original reason for this was that IE8 didn't support it. Thankfully we don't need to worry about that anymore.

@pkozlowski-opensource
Copy link
Member Author

Not sure IE8 was the reason as it was introduced only in 1.3. Here is the initial commit: a70e283

I guess @caitp knows more - was the current code perf-motivated?

@caitp
Copy link
Contributor

caitp commented Nov 29, 2014

I thought we already merged @shahatas refactoring

@pkozlowski-opensource
Copy link
Member Author

no, we didn't as it was part of more changes in #9745 (this is why it is always good idea to send small, focused PRs :-))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants