This repository was archived by the owner on Apr 12, 2024. It is now read-only.
doc(injector): adds strictDi documentation to appropriate methods. #10180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks Rado! |
| @@ -159,7 +160,8 @@ function annotate(fn, strictDi, name) { | |||
| * | |||
| * In JavaScript calling `toString()` on a function returns the function definition. The definition | |||
| * can then be parsed and the function arguments can be extracted. *NOTE:* This does not work with | |||
| * minification, and obfuscation tools since these tools change the argument names. | |||
| * minification, and obfuscation tools since these tools change the argument names. This method of | |||
There was a problem hiding this comment.
I would move the sentence before the "NOTE".
|
Couple of comments, otherwise LGTM! |
| @@ -1332,7 +1332,7 @@ function angularInit(element, bootstrap) { | |||
| * following keys are supported: | |||
| * | |||
| * - `strictDi`: disable automatic function annotation for the application. This is meant to | |||
| * assist in finding bugs which break minified code. | |||
| * assist in finding bugs which break minified code. Defaults to false. | |||
There was a problem hiding this comment.
Should include backticks for formatting: false
|
Left a comment. Other than that, LGTM. |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
CLAs look good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9624