docs(CHANGELOG): add info about $parse breaking change in 1.3.3

[pkozlowski-opensource]

Closes #10054

[googlebot]

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

[Narretz]

Oops, we did it again - breaking change. ;)

I think we should add the info about naming filters to https://docs.angularjs.org/guide/filter and https://docs.angularjs.org/api/ng/provider/$filterProvider too

[lgalfaso]

It would be nice to throw when trying to register a filter that is not an
identifier

[mary-poppins]

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

[pkozlowski-opensource]

@Narretz I would be too keen on documenting it everywhere - the fact that it was supported was really an accident, IMO

[googlebot]

CLAs look good, thanks!

[jeffbcross]

@mary-poppins this is awkward... we actually don't need you anymore

[gkalpak]

Hey, don't deprecate @mary-poppins for some ...bot !!!

[petebacondarwin]

@pkozlowski-opensource - this looks good but I agree that it should documented - but in a positive sense. Something along the lines of:

Filter names must be valid angular expression identifiers, such as uppercase and orderBy. Names with special characters, such as hyphens and dots, are not allowed.

[pkozlowski-opensource]

@petebacondarwin are you referring to some additional documentation on a page dedicated to filters? Or rewording the breaking change section text?

[petebacondarwin]

Extra docs on filter api page
On 20 Nov 2014 14:39, "Pawel Kozlowski" [email protected] wrote:

@petebacondarwin https://github.com/petebacondarwin are you referring
to some additional documentation on a page dedicated to filters? Or
rewording the breaking change section text?

—
Reply to this email directly or view it on GitHub
#10131 (comment).

[pkozlowski-opensource]

OK, added a note to the filters guide as well.