docs(ngAnimate.$animate): fix classes during the various animation phases #10124
Conversation
| * | 12. The element is removed from the DOM | ... | | ||
| * | 13. The returned promise is resolved. | ... | | ||
| * | 12. The element is removed from the DOM | class="my-animation" | | ||
| * | 13. The returned promise is resolved. | class="my-animation" | |
There was a problem hiding this comment.
I think these are wrong, since the DOM element in question has been removed from the DOM and so ... seems more appropriate.
gkalpak
force-pushed
the
ngAnimate-fix-docs
branch
from
3f2d618 to
089e4a4
Compare
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
gkalpak
force-pushed
the
ngAnimate-fix-docs
branch
from
089e4a4 to
92854f7
Compare
|
@petebacondarwin: Rebased and addressed your comments (except for the whitespace; see #10124 (comment)). |
|
@mary-poppins: You think ? |
|
CLAs look good, thanks! |
I am not 100% sure for the class additions (although I am 99+% sure).
(If someone could double-check (@matsko ideally ?), that would be great 😃)