Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(docs): plnkr examples should open in new window #8328

Closed
jeffbcross opened this issue Jul 24, 2014 · 0 comments
Closed

feat(docs): plnkr examples should open in new window #8328

jeffbcross opened this issue Jul 24, 2014 · 0 comments

Comments

@jeffbcross
Copy link
Contributor

Previously, "Edit in Plunker" links from the API reference docs would open plunker in a new window. However, pop up blockers would frequently block the new window unless a user explicitly allowed popups from the domain. Even manually clicking through to the link would not populate the plunker with the correct template because the feature relied on posting FormData to plunker which would be clobbered by the popup blocker. This was temporarily fixed by #8327 which posts the form in the same window.

Presumably, the pop-up blocker was not allowing the new window to open because the submission of the form was not happening within the context of a user event (the click), but was instead waiting on some data to be loaded over XHR, then submitted to plunker.

A better user experience would be to have the form and form-date pre-populated on the page, and immediately submit the form within ngClick.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants