-
Notifications
You must be signed in to change notification settings - Fork 27.4k
ngMockE2E points to incorrect script locations in docs #8038
Comments
The installation block is automatically inserted by dgeni.ngdoc (module template. https://github.com/angular/dgeni-packages/blob/master/ngdoc/templates/api/module.template.html) |
Wouldn't it be best to split the ngMockE2E out into its own javascript file and then let it work as normal? |
This is related to and can be solved in the same way as #7284 |
Yeh, we should close this one as a duplicate of #7284. Sorry @petebacondarwin , kind of didn't have time to look more into this one :-/ |
@pkozlowski-opensource - I am on it. I am not sure it is an exact duplicate, since @krimple would really like ngMockE2E to be packaged separately. This could be worth it. I expect that ngMockE2E it could be deprecated since ngScenario is being replaced by Protractor. |
@petebacondarwin why is ngMockE2E less relevant with protractor than it was with ngScenario? |
Oops. @shahata - yes you are right. One can still implement ngMockE2E:$httpBackend if you want even if you use Protractor. |
The ngMockE2E module is not available in the locations shown, it is embedded in the angular-mocks.js script. Either make the file available as a separate script (which has the advantage of letting you use ngMockE2E in a production setting without forcing you to use the mock $log) or update the docs to point to the angular-mocks.js location.
The URL in question on the site: https://docs.angularjs.org/api/ngMockE2E
I tried the "improve this doc" link but couldn't find any reference to the links in the current repo.
The text was updated successfully, but these errors were encountered: