Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngMockE2E points to incorrect script locations in docs #8038

Closed
krimple opened this issue Jul 1, 2014 · 7 comments
Closed

ngMockE2E points to incorrect script locations in docs #8038

krimple opened this issue Jul 1, 2014 · 7 comments

Comments

@krimple
Copy link

krimple commented Jul 1, 2014

The ngMockE2E module is not available in the locations shown, it is embedded in the angular-mocks.js script. Either make the file available as a separate script (which has the advantage of letting you use ngMockE2E in a production setting without forcing you to use the mock $log) or update the docs to point to the angular-mocks.js location.

The URL in question on the site: https://docs.angularjs.org/api/ngMockE2E

I tried the "improve this doc" link but couldn't find any reference to the links in the current repo.

@Narretz
Copy link
Contributor

Narretz commented Jul 21, 2014

The installation block is automatically inserted by dgeni.ngdoc (module template. https://github.com/angular/dgeni-packages/blob/master/ngdoc/templates/api/module.template.html)
@petebacondarwin Is there a way to overwrite this behavior?

@Narretz Narretz added this to the 1.3.0 milestone Jul 21, 2014
@krimple
Copy link
Author

krimple commented Jul 21, 2014

Wouldn't it be best to split the ngMockE2E out into its own javascript file and then let it work as normal?

@petebacondarwin
Copy link
Contributor

This is related to and can be solved in the same way as #7284

@pkozlowski-opensource
Copy link
Member

Yeh, we should close this one as a duplicate of #7284. Sorry @petebacondarwin , kind of didn't have time to look more into this one :-/

@petebacondarwin
Copy link
Contributor

@pkozlowski-opensource - I am on it.

I am not sure it is an exact duplicate, since @krimple would really like ngMockE2E to be packaged separately. This could be worth it. I expect that ngMockE2E it could be deprecated since ngScenario is being replaced by Protractor.

@shahata
Copy link
Contributor

shahata commented Jul 21, 2014

@petebacondarwin why is ngMockE2E less relevant with protractor than it was with ngScenario?

@petebacondarwin
Copy link
Contributor

Oops. @shahata - yes you are right. One can still implement ngMockE2E:$httpBackend if you want even if you use Protractor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants