replace directive $element still references replaced DOM element

[jbedard]

...if using jQuery instead of jqLite because the jQuery $element still references the replaced DOM element as the context. This only occurs if the element is replaced and not cloned since cloning creates a new jQuery object instead of just modifying the compiled $element. (http://plnkr.co/edit/vGwzc1FGt127pQ1wbKNT?p=preview)

This isn't huge, and isn't really a memory leak because it will get destroyed along with the $element, but it would be nice if the replaced DOM was cleaned up. I think this can be fixed in the $compile replaceWith helper by properly clearing the jQuery context...

edit: I originally had something about replace & -start/end in here too but that seems unrelated.

[mgol]

The next Angular 1.3.0 beta will support jQuery 2.1 (and will not officially support older versions though they should work). The relevant commit: 9e7cb3c

The beta should be released in about a week. Before that happens, you can check if the issue still exists by trying the snapshot Angular version: https://code.angularjs.org/snapshot/angular.js

Don't use it in production, though, wait for a proper release.

[jbedard]

jQuery 2 hasn't changed .context so the issue will still exist. Here's an updated plunker using the angular snapshot and jQuery 2.1: http://plnkr.co/edit/A1DFKQqTqEKPR2NJpsIz?p=preview

[mgol]

Thanks, I'll look into it.

[petebacondarwin]

@mzgol - I am assuming that you are taking this one?

[mgol]

Yes, I'll get it merged soon.

[caitp]

@mzgol if you land the stuff you're confident is ready to go, I don't think the tree should be brittle now (could be wrong though!)