Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ng-animate class not removed if removeClass() called before addClass() completes #7801

Closed
georeith opened this issue Jun 12, 2014 · 0 comments

Comments

@georeith
Copy link

I have reproduced an example of this issue at http://jsbin.com/vahokopa/2/.

The issue occurs when a custom JavaScript animation is added via the $animate.addClass() function and is accompanied by $animate.removeClass(). If the done function is not passed before the animation gets cancelled (removeClass is called during addClass) the ng-animate class is never removed from the element once the removeClass function has completed (and vice-versa).

To see the issue just click anywhere in the output window on my example twice within 2 seconds.

This can be problematic if you are using the .ng-animate class to apply styles during an animation.

matsko pushed a commit to matsko/angular.js that referenced this issue Jun 13, 2014
matsko pushed a commit to matsko/angular.js that referenced this issue Jun 13, 2014
matsko pushed a commit to matsko/angular.js that referenced this issue Jun 13, 2014
matsko pushed a commit to matsko/angular.js that referenced this issue Jun 23, 2014
matsko pushed a commit to matsko/angular.js that referenced this issue Jun 23, 2014
matsko pushed a commit to matsko/angular.js that referenced this issue Jul 1, 2014
@matsko matsko closed this as completed in e18db78 Jul 1, 2014
ckknight pushed a commit to ckknight/angular.js that referenced this issue Jul 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant