This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Update contribution docs concerning cross-browser tests #7303
Comments
Thanks @RichardLitt! |
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Oct 24, 2017
- remove outdated info - add info about writing docs from Wiki - add info about development setup from docs contribute.md - add info about running tests on Saucelabs / Browserstack TODO: - add link to contributing.md to Contribung page - add link to changelog.md to dropdown in docs -- link to current version changelog entry? Closes angular#7303 Closes angular#9444
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Oct 24, 2017
- remove outdated info - add info about writing docs from Wiki - add info about development setup from docs contribute.md - add info about running tests on Saucelabs / Browserstack TODO: - add link to contributing.md to Contribung page - add link to changelog.md to dropdown in docs -- link to current version changelog entry? Closes angular#7303 Closes angular#9444
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Oct 24, 2017
- remove outdated info - add info about writing docs from Wiki - add info about development setup from docs contribute.md - add info about running tests on Saucelabs / Browserstack TODO: - add link to contributing.md to Contribung page - add link to changelog.md to dropdown in docs -- link to current version changelog entry? Closes angular#7303 Closes angular#9444
3 tasks
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Oct 24, 2017
- remove outdated info - add info about writing docs from Wiki - add info about development setup from docs contribute.md - add info about running tests on Saucelabs / Browserstack TODO: - add link to contributing.md to Contribung page - add link to changelog.md to dropdown in docs -- link to current version changelog entry? Closes angular#7303 Closes angular#9444
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Oct 25, 2017
- remove outdated info - add info about writing docs from Wiki - add info about development setup from docs contribute.md - add info about running tests on Saucelabs / Browserstack TODO: - add link to contributing.md to Contribung page - add link to changelog.md to dropdown in docs -- link to current version changelog entry? Closes angular#7303 Closes angular#9444
Narretz
added a commit
that referenced
this issue
Nov 3, 2017
CONTRIBUTING.md - focus on basic info about issues and pull requests for new contributors - move development heavy info to DEVELOPERS.md + add links - remove outdated info DEVELOPERS.md - contains info about project setup, coding rules, and commit message guidelines from CONTRIBUTING.md - add and update info about writing docs from Wiki - add info about development setup from docs contribute.md - add info about running tests on Saucelabs / Browserstack Closes #7303 Closes #9444 Closes #16297
THanks, @Narretz! |
Narretz
added a commit
that referenced
this issue
Nov 17, 2017
CONTRIBUTING.md - focus on basic info about issues and pull requests for new contributors - move development heavy info to DEVELOPERS.md + add links - remove outdated info DEVELOPERS.md - contains info about project setup, coding rules, and commit message guidelines from CONTRIBUTING.md - add and update info about writing docs from Wiki - add info about development setup from docs contribute.md - add info about running tests on Saucelabs / Browserstack Closes #7303 Closes #9444 Closes #16297
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are more tests that run on the Travis server than are listed in the unit testing section in the Contribute docs.
grunt test:unit
doesn't include the cross-browser tests, and there are no instructions on how to run all of the tests that are run on Travis. Also, some of the tests listed as possible in the docs don't work on a clean, updated fork - note Opera not being registered, below.There may be an easy fix to this; for instance, suggesting that the users set up a Saucelabs account, or use Travis's, or that they preinstall a few extra modules. Either way, it should be in the docs.
Version: v1.3.0-beta.7
Reproducible: Always
OS: OSX 10.9.2
Steps to reproduce:
grunt test:unit --browsers Opera,Firefox
The text was updated successfully, but these errors were encountered: