Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Step 4, no default order and what it means #5730

Closed
cfjedimaster opened this issue Jan 10, 2014 · 2 comments
Closed

Step 4, no default order and what it means #5730

cfjedimaster opened this issue Jan 10, 2014 · 2 comments
Assignees

Comments

@cfjedimaster
Copy link

On step 4 (http://docs.angularjs.org/tutorial/step_04), the docs say this about what would happen if there were no default order in the controller:

"If we had not set the default value here, the model would stay uninitialized until our user picks an option from the drop down menu."

But then you go down to the experiments section and it says this:

"In the PhoneListCtrl controller, remove the statement that sets the orderProp value and you'll see that Angular will temporarily add a new "unknown" option to the drop-down list and the ordering will default to unordered/natural order."

This contradicts the earlier statement. The experiment text is correct, but the first statement leads you to believe that Angular won't be able to render the list at all.

@Narretz
Copy link
Contributor

Narretz commented Jan 10, 2014

The first statement means that the orderBy model for the filter would not be initalized, which does not mean the phones model (list). Maybe this should be clarified.

@cfjedimaster
Copy link
Author

I'd agree that just a little clarification would be nice. I really read it as "it wouldn't render"

@ghost ghost assigned naomiblack Jan 11, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants