$timeout example not working #5232
Comments
|
Yes you are right. This is because there was an issue with $timeout and e2e tests - so there was a hack in there to change how timeouts were run in the docs. |
ghost
assigned
|
I have fixed this by removing the hack and changing the end2end test (which was in guide/directive) to use $interval. But I realised that the example for $timeout is actually no longer appropriate. This example is exactly what $interval is for. So I am going to move the over there instead. Perhaps someone would like to suggest a better $timeout example that doesn't involve timeouts that trigger themselves, which is what interval is for. |
End 2 end tests wait for all `$timeout`s to be run before completing the test. This was problematic where we were using timeouts that restarted themselves because there would never be a point when all timeouts had completed, causing the tests to hang. To fix this $timeout had been monkey-patched but this caused other issue itself. Now that we have $interval we don't need to use $timeout handlers that re-trigger the $timeout so we can ditch the monkey-patch. This commit tidies up any examples that are using this approach and changes them to use $interval instead. Closes angular#5232
End 2 end tests wait for all `$timeout`s to be run before completing the test. This was problematic where we were using timeouts that restarted themselves because there would never be a point when all timeouts had completed, causing the tests to hang. To fix this $timeout had been monkey-patched but this caused other issue itself. Now that we have $interval we don't need to use $timeout handlers that re-trigger the $timeout so we can ditch the monkey-patch. This commit tidies up any examples that are using this approach and changes them to use $interval instead. Closes angular#5232
The example of ng.$timeout does not work, as it is the only manually written docs, I think it would be worth it to correct it. The StopFight button has no effect on the countdown.
I am using chromium 31.0.1650.48 on archlinux (gnome).
The text was updated successfully, but these errors were encountered: