Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs app: version switcher claims that 1.2.0 is unstable #4908

Closed
IgorMinar opened this issue Nov 12, 2013 · 2 comments
Closed

docs app: version switcher claims that 1.2.0 is unstable #4908

IgorMinar opened this issue Nov 12, 2013 · 2 comments
Assignees
@matsko
Labels
type: docs
Milestone
1.2.1 - underscor...

Comments

@IgorMinar
Copy link
Contributor

1.2.0 and 1.2.0+ should be "stable".

at this point we could just remove the unstable versions from the version switcher. no?
@ghost ghost assigned matsko Nov 12, 2013
@petebacondarwin
Copy link
Contributor

I think that, instead, the logic for deciding what is stable should be fixed.

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Nov 12, 2013
@petebacondarwin
docs(ngdoc): fix version picker grouping
d7f164a 
The grouping of the different versions was not correct for the new 1.2.0+ releases.
Now versions are marked as stable only if they have an even number it the minor version
position (e.g. 1.0.8, 1.2.1, 1.2.0-abcde) and they are not an RC version, (e.g. 1.0.0rc3,
1.2.0-rc2).

Closes angular#4908
@petebacondarwin petebacondarwin mentioned this issue Nov 12, 2013
Closed
@petebacondarwin
Copy link
Contributor

Here is a PR that does this: #4909.

You can see it in action at http://ci.angularjs.org/job/angular.js-pete/359/artifact/build/docs/index.html.

Note that since the build process does not checkout the entire git repository some of the tags are missing and so their versions are not shown in the drop-down. This is the case for any builds of the docs you care to look at . If you build and test locally you get all the versions.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@petebacondarwin @jamesdaily
docs(ngdoc): fix version picker grouping
59e4bba 
The grouping of the different versions was not correct for the new 1.2.0+ releases.
Now versions are marked as stable only if they have an even number it the minor version
position (e.g. 1.0.8, 1.2.1, 1.2.0-abcde) and they are not an RC version, (e.g. 1.0.0rc3,
1.2.0-rc2).

Closes angular#4908
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@petebacondarwin @jamesdaily
docs(ngdoc): fix version picker grouping
d407fb4 
The grouping of the different versions was not correct for the new 1.2.0+ releases.
Now versions are marked as stable only if they have an even number it the minor version
position (e.g. 1.0.8, 1.2.1, 1.2.0-abcde) and they are not an RC version, (e.g. 1.0.0rc3,
1.2.0-rc2).

Closes angular#4908
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
type: docs
Projects
None yet
Milestone
1.2.1 - underscore-empathy
Development

Successfully merging a pull request may close this issue.

docs(ngdoc): fix version picker grouping petebacondarwin/angular.js
3 participants
@petebacondarwin @matsko @IgorMinar