regression - cannot override blur event - Angular 1.2.0.rc3

[regis-leray]

Im trying to override the blur event, but with 1.2.0-rc.3 it is broken

angular.module('mydirectives', []).directive('ngModelOnblur', function() {
        return {
            restrict: 'A',
            require: 'ngModel',
            link: function(scope, elm, attr, ngModelCtrl) {
                if (attr.type === 'radio' || attr.type === 'checkbox') return;

                elm.unbind('input').unbind('keydown').unbind('change');
                elm.bind('blur', function() {
                    scope.$apply(function() {
                        ngModelCtrl.$setViewValue(elm.val());
                    });
                });
            }
        };
});

html using directive

 <input id="email" type="email" ng-model="user.email" name="userEmail" required ng-model-onblur/>
      <div ng-show="form.userEmail.$error.email" class="alert-error alert-msg">the email is not valid</div>

If you change the version to 1.2.0-rc2 of angular it s working.
http://plnkr.co/edit/dRT5nh?p=preview

thanks

PS: maybe it is the unbind function, or something else

[regis-leray]

by adding the priority to 1 is working now with the version angular.1.2.0-rc3

  angular.module('mydirectives', []).directive('ngModelOnblur', function() {
    return {
        restrict: 'A',
        priority:1,
        require: 'ngModel',
        link: function(scope, elm, attr, ngModelCtrl) {
            if (attr.type === 'radio' || attr.type === 'checkbox') return;

            elm.unbind('input').unbind('keydown').unbind('change');
            elm.bind('blur', function() {
                scope.$apply(function() {
                    ngModelCtrl.$setViewValue(elm.val());
                });
            });
        }
    };

});

Please close the ticket.

[btford]

Glad you figured it out. :)

[caitp]

Actually, I'm not sure this is working in 1.2.6, there was a different issue regarding/related to this recently and it appeared that the input/textarea/select directives would always be executed after the custom directive, regardless of the directive priority. It seemed like element directives were always being applied last, therefore the only way to properly override certain functionality was to wrap it in a $timeout.

It was super-weird, but hey, maybe there's actually something to it.

[btford]

@caitp, do you happen to have the # of the relevant issue?

[caitp]

I can't recall if it was on github or irc, but I believe I have some plunkrs showing it, so let me see if I can dig those up

[caitp]

Yeah, so I guess it was reported on IRC, but it seems to be a legitimate thing. They're attempting to override the $render function of an ngModelController, but unfortunately the textarea directive always gets the last laugh. I'd tried both extremely low/negative and extremely high priorities, and playing with the directive name, but no matter what I did it always seemed to run the element directive's link function last. http://plnkr.co/edit/tDldpQ?p=preview

I haven't really dug into why, so it's possible I was doing something wrong, but it seemed legitimate. In the end I just sort of gave up and said wrap it in a $timeout, seemed to work for them, but maybe not ideal

[Narretz]

@caitp For what it's worth, overriding blur and overriding the $render method are different things, so maybe it's better to close this and to open another issue with the $render problem.
e: turns out there is already an issue: #4560
Setting a positive priority also makes your plunkr work: http://plnkr.co/edit/Yrva8o?p=preview
(at least the binding)

[caitp]

@Narretz what's really happening is that the element directive input always seemed to be linked the last, regardless of directive priority. Which seems very strange. But anyways, this would mean that setting any properties of the model controller could be overwritten by the input directive.

So what they're doing is trying to unbind an event, which hasn't been bound yet. This isn't going to work as expected, because the input directive is still going to bind to that event when it's linked. The whole thing is a weird ordering issue, which seems to have changed at some point during 1.2 cycle --- possibly the change to the postlink order, but I'm not sure about that. In any case, the element directive is consistently being linked last, and I haven't really looked into why that is.

Is this a legitimate bug, or working as expected? Hard to say